Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors with scipy 1.13 related to importing window functions improperly #944

Open
bhazelton opened this issue Apr 4, 2024 · 2 comments
Open

Comments

@bhazelton
Copy link
Member

I'm seeing errors in hera_cal runs on pyuvdata related to improper scipy imports with scipy v1.13

The release notes for Scipy 1.11 say:

Importing window functions directly from scipy.window has been soft deprecated since SciPy 1.1.0. They now raise a DeprecationWarning and will be removed in SciPy 1.13.0. Users should instead import them from scipy.signal.window or use the convenience function scipy.signal.get_window.

@jsdillon
Copy link
Member

I believe hera_cal only uses scipy windows via aipy or hera_filters... but I could be wrong. Can you share the errors so we can track them down?

@tyler-a-cox
Copy link
Contributor

Looking at the error in the pyuvdata tests, it looks like this is actually an issue with hera_sim which is being called in the hera_cal tests. Steven opened a PR in hera_sim that should take care of this HERA-Team/hera_sim#305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants