Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frequency handling in frf.build_fringe_rate_profiles #919

Open
r-pascua opened this issue Nov 7, 2023 · 1 comment
Open

Improve frequency handling in frf.build_fringe_rate_profiles #919

r-pascua opened this issue Nov 7, 2023 · 1 comment
Assignees

Comments

@r-pascua
Copy link
Contributor

r-pascua commented Nov 7, 2023

There have been multiple cases of users having unexpected results crop up when using frf.build_fringe_rate_profiles which ultimately trace back to how the frequency axis is handled within the function. The way in which the frequency axis is incorrectly handled is complicated to explain, but it is prone to silent bugs that are difficult to debug without going over the function's code line-by-line. This function's code should be cleaned up to remedy this.

@r-pascua r-pascua self-assigned this Nov 7, 2023
@jsdillon
Copy link
Member

jsdillon commented Nov 7, 2023

I'll just add this link to the relevant slack chat for posterity: https://eoranalysis.slack.com/archives/C03DK432S4S/p1699041990832489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants