Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jax optional install? #905

Open
nkern opened this issue Jul 24, 2023 · 1 comment
Open

make jax optional install? #905

nkern opened this issue Jul 24, 2023 · 1 comment
Assignees

Comments

@nkern
Copy link
Member

nkern commented Jul 24, 2023

as of a few months ago an import jax statement was added to abscal.py without any exceptions, making jax a requirement for building hera_cal. I don't think jax is particularly hard to build, but it is a somewhat niche dependency and not needed in general to run most of the useful utilities in hera_cal. can we make this an optional dependency with a try: except: statement whereever jax is imported?

alternatively, if ppl feel that jax is an indispensable and widely used tool within hera_cal (which I don't think is the case), then let's formally make jax a dependency in the docs.

@jsdillon
Copy link
Member

We've been lax in updating the docs, but I do believe it's in the configs for when you pip install. I think we want to move toward using jax more as we find more places it allows speed-ups, so I'm generally in favor of making it mandatory (it's a lot less heavy and finicky to install than something like tensorflow or pytorch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants