Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to detect existing SSL certs before regenerating them #8

Open
micahjsmith opened this issue May 9, 2017 · 0 comments
Open

Try to detect existing SSL certs before regenerating them #8

micahjsmith opened this issue May 9, 2017 · 0 comments
Assignees

Comments

@micahjsmith
Copy link
Member

LetsEncrypt limits the number of certificates that can be consecutively generated for the same domain. If full integration tests, that generated SSL certs, are repeatedly run (or if the entire build process is run for some other reason), then this causes an error. As a temporary fix, we break out the routine from make build to a separate make ssl, but a better approach would be to check if certificates exist in the secrets volume before trying to regenerate them.

@micahjsmith micahjsmith self-assigned this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant