Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal unit tests #28

Open
bcyphers opened this issue Dec 24, 2017 · 4 comments
Open

Add minimal unit tests #28

bcyphers opened this issue Dec 24, 2017 · 4 comments

Comments

@bcyphers
Copy link
Contributor

Right now there are just a couple of actual tests in the test/ folder, and they leave huge portions of the code untouched.

Eventually, we will need a suite of unit tests and comprehensive integration tests that reasonably convince us that a new change won't break anything. We'll also want to integrate with CircleCI and github so that we can evaluate pull requests from the web (but that will come later).

I'll try to update this issue with our progress as time goes on, but a good start would be unit tests for:

  • each hyperpartition for each classification method
  • each database.py create/query/update function
  • hyperpartition enumeration
  • hyperpartition selection/parameter tuning
  • metric computation in metrics.py
  • data loading and encoding with a variety of quirky data types
  • serialization/deserialization of models/metrics objects
@bcyphers
Copy link
Contributor Author

bcyphers commented Jan 2, 2018

On second thought, maybe we should get CircleCI up and running first with the couple of tests we do have.

@bcyphers bcyphers changed the title We need tests! We need more tests! Feb 9, 2018
@takabayashi
Copy link

Hey guys, I want to Help with the unit tests. Which one is the easiest class to start??

@micahjsmith micahjsmith changed the title We need more tests! Add minimal unit tests Feb 19, 2019
@micahjsmith
Copy link
Member

Hey @takabayashi, thanks for your interest in helping. The metrics are pretty self contained and could be a good place to start. The database functionality is straightforward if you can get the mocking done properly. And the utilities have a variety of isolated functions that could be tested.

@takabayashi
Copy link

Ok great I will try to build the environment, any problem I'II post here...thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants