Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<mj-social-element> puts text inside <img> element #267

Open
stevedrobinson opened this issue Nov 23, 2021 · 0 comments
Open

<mj-social-element> puts text inside <img> element #267

stevedrobinson opened this issue Nov 23, 2021 · 0 comments

Comments

@stevedrobinson
Copy link

stevedrobinson commented Nov 23, 2021

When I compare the behavior between https://mjml.io and their "Try it Live" editor and grapejs-mjml, they treat the tag diffferently.

mjml.io renders the <mj-social-element> tag with the icon next to text using two table cells, one for the image, and one for the text sort of like this (this is super simplified):

<table>
  <tr>
    <td>
        <a><img/></a>
    </td>
    <td>
      <a>text</a>
    </td>
  </tr>
</table>

When grapesjs-mjml renders the <mj-social-element> it renders it like this:

<table>
  <tr>
    <td>
      <a><img>text</img></a>
    </td>
  </tr>
</table>

I don't think this is intentional, since putting text inside of an image tag is pretty unusual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant