PERMISSION_DENIED when provisioning ProducerDestination in spring-cloud-gcp-pubsub-stream-binder

[Manujsa]

Hi Team,
Putting this bug related to Producer Destination , Earlier you guys fixed similar kind of issue for Consumer Destination as part of this ticket #1348. On the similar note you also need to fix it for Producer Destination, it still exists for ProducerDestination in latest 5.6.0 version in PubSubChannelProvisioner._ It uselessly enter into ensureTopicExists method and search for this.pubSubAdmin.getTopic(topicName) while auto-create-resources=false that required additional pubsub.get.topics permission for SA .

Current Implementation:

@Override
public ProducerDestination provisionProducerDestination(
  String topic, ExtendedProducerProperties properties) {
  ensureTopicExists(topic, properties.getExtension().isAutoCreateResources());

  return new PubSubProducerDestination(topic);
}

Required Implementation:

@Override
public ProducerDestination provisionProducerDestination(
  String topic, ExtendedProducerProperties properties) {

  boolean autoCreate = properties.getExtension().isAutoCreateResources();

  // topicName may be either the short or fully-qualified version.
  String topicShortName =
    TopicName.isParsableFrom(topicName) ? TopicName.parse(topicName).getTopic() : topicName;
  if (autoCreate) {
    ensureTopicExists(topicShortName, autoCreate);
  }
  return new PubSubProducerDestination(topic);
}

Please fixed it and update us here !

[burkedavison]

Source reference:

spring-cloud-gcp/spring-cloud-gcp-pubsub-stream-binder/src/main/java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java

Lines 57 to 63 in e04f755

	@Override
	public ProducerDestination provisionProducerDestination(
	String topic, ExtendedProducerProperties<PubSubProducerProperties> properties) {
	ensureTopicExists(topic, properties.getExtension().isAutoCreateResources());
	return new PubSubProducerDestination(topic);
	}

ensureTopicExists currently throws a ProvisionerException for topics that don't exist when auto-create-resources is false. A side-effect of this suggestion would be that this exception would no longer be thrown.

(I'm not currently advocating for or against this request.)