Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

--upgrade-config is faulty migrating sendTopic and sendNonMsg to relayIRCEvents #221

Open
petebp opened this issue Nov 17, 2017 · 0 comments
Labels

Comments

@petebp
Copy link

petebp commented Nov 17, 2017

With v0.4.8 the sendTopic and sendNonMsg config options were migrated to relayIRCEvents, which allows you to select the forwarded messages more accurate.

But for now config.sendTopic and config.sendNonMsg are only renamed to config.relayIRCEvents. That will result in ambiguous configurations, since there will be two lines for config.relayIrcEvents, which probably set to true and false, if sensNonMsg and sendTopic had different values before. Also, the documentation in the config file is not explaining what's the effect of setting relayIRCEvents to true or false.

The better solution would to fill the array for relayIRCEvents 'topic' if sendtopic were set to true, and at least 'join', 'part', 'quit' if sendNonMsg were set to true in the old config. The should also be a proper decision found for the other allowed options of relayIRCEvents.

@Mikaela Mikaela added the bug label Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants