From 35b1489834502634a0247626c4c2d225fe2e7279 Mon Sep 17 00:00:00 2001 From: Jakub Kadlcik Date: Wed, 11 Sep 2024 20:27:52 +0200 Subject: [PATCH] backend: first sign packages, then upload them to Pulp --- backend/copr_backend/background_worker_build.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/backend/copr_backend/background_worker_build.py b/backend/copr_backend/background_worker_build.py index abe350218..08e5b1b98 100644 --- a/backend/copr_backend/background_worker_build.py +++ b/backend/copr_backend/background_worker_build.py @@ -696,12 +696,6 @@ def _sign_built_packages(self): :param pkg: path to the source package """ - - # Ideally, we would like to have this decision in our storage classes - if self.job.storage == StorageEnum.pulp: - self.log.info("Not going to sign pkgs, Pulp will take care of that") - return - self.log.info("Going to sign pkgs from source: %s in chroot: %s", self.job.task_id, self.job.chroot_dir) @@ -1019,12 +1013,12 @@ def build(self, attempt): # raise error if build failed try: - self._upload_results_to_storage() self._check_build_success() # Build _succeeded_. Do the tasks for successful run. failed = False if self.opts.do_sign: self._sign_built_packages() + self._upload_results_to_storage() self._do_createrepo() self._parse_results() build_details = self._get_build_details(self.job)