Attempt to fix the color consistency issue #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge thanks for this. Will check it out shortly. |
xurei
force-pushed
the
bugfix/color-space-91
branch
from
1721722
to
5826266
Compare
|
https://github.com/all-contributors please add @xurei for code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
srgb_nonlinear_to_linearin therender_output.effecteffect so colors stay consistent.I'm not 100% sure it will solve all the color consistency problems. More tests are required to make sure all is good (especially trying sources with other color scheme than sRGB).
Also, alpha channel is still causing troubles. See attached video
Note that this PR is partially based on the work made in branch
bugfix/color-space2023-12-13.14-34-35.mp4