Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Composite Background option not working when filtered source is cropped. #20

Closed
FiniteSingularity opened this issue Aug 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@FiniteSingularity
Copy link
Owner

Describe the bug
If a filtered source that uses background source for compositing option, is cropped, the background compositing is no longer performed.

To Reproduce
Steps to reproduce the behavior:

  1. Make a chroma-keyed facecam.
  2. Place a solid light colored source behind the chroma keyed facecam.
  3. Apply a gaussian blur to the face cam.
  4. Set the color source as background source for compositing.
  5. Witness the dark aura around the facecam.

Expected behavior
The facecam blur should not have a dark aura.

Screenshots
Before cropping
image

After cropping
image

Environment

  • OS/Version: Windows 11
  • OBS Version: Some dev version
  • OBS Composite Blur Plugin Version: 0.0.7-alpha with Exeldros PR merged in
  • Blur Algorithm/Type: All

GPU

  • GPU make/model: Nvidia RTX 3800
  • GPU VRAM: 12Gb
@FiniteSingularity FiniteSingularity added the bug Something isn't working label Aug 31, 2023
@FiniteSingularity
Copy link
Owner Author

A Workaround is to turn off SRGB blending off for the blurred source (facecam in the example above).

image

This seems to be due to a different rendering pipeline being used for cropped sources. See https://github.com/obsproject/obs-studio/blob/321829d9324f7b82ef362ccc85f6dd053865080c/libobs/obs-scene.c#L550 (Thanks @exeldro for finding this).

@exeldro
Copy link
Contributor

exeldro commented Aug 31, 2023

might need look into source output flag OBS_SOURCE_SRGB and video_get_color_space from the struct obs_source_info
like: https://github.com/obsproject/obs-studio/blob/321829d9324f7b82ef362ccc85f6dd053865080c/plugins/obs-filters/nvidia-greenscreen-filter.c#L1068

exeldro added a commit to exeldro/obs-composite-blur that referenced this issue Sep 1, 2023
this should be fixing FiniteSingularity#20
exeldro added a commit to exeldro/obs-composite-blur that referenced this issue Sep 1, 2023
this should be fixing FiniteSingularity#20
@exeldro exeldro mentioned this issue Sep 1, 2023
exeldro added a commit to exeldro/obs-composite-blur that referenced this issue Oct 2, 2023
this should be fixing FiniteSingularity#20
@FiniteSingularity
Copy link
Owner Author

This appears to have been fixed by #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants