Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong function to save pvd files in examples and docs #1055

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Sep 18, 2024

This was a mistake in #1015, close is not defined for pvd files by WriteVTK, so users have to use vtk_save instead for saving pvd files.

@KnutAM KnutAM requested a review from lijas September 18, 2024 10:59
Copy link
Collaborator

@lijas lijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this not error? Is close(pvd) defined somewhere?

@KnutAM KnutAM merged commit 31096cb into master Sep 18, 2024
8 of 9 checks passed
@KnutAM KnutAM deleted the kam/fixpvdexamples branch September 18, 2024 11:58
@KnutAM
Copy link
Member Author

KnutAM commented Sep 18, 2024

After JuliaVTK/WriteVTK.jl#149 this would actually not have been required.
Should we revert now @fredrikekre?
Or maybe reasonable to use vtk_save for some time before updating to the latest version of WriteVTK (we should also call close internally in Ferrite then probably)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants