Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feautre: @JsonIgnoreIf on base 2.14 #3375
base: 2.14
Are you sure you want to change the base?
New feautre: @JsonIgnoreIf on base 2.14 #3375
Changes from all commits
27d963c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but isn't the issue with implementing this in
JacksonAnnotationIntrospector
that introspection is supposed to be cached in theObjectMapper
which would mean that these conditionals would only be computed statically? I guess the use-case for the annotation introduced here actually meant just-in-time / during serialization authorization checks. I think currently only a@PropertyFilter
is suitable for that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwgmeligmeyling Yes, you are correct: this would not work as intended for reasons you outline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be changed, handlers would need to be instantiated using
HandlerInstantiator
as is done with other helper objects. Alas, method is not yet passedMapperConfig
and it's not trivial to get it there...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
um, definitely not. :)