Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@chris) Copy data from different user in library #582

Open
rudolphpienaar opened this issue Aug 11, 2022 · 6 comments
Open

(@chris) Copy data from different user in library #582

rudolphpienaar opened this issue Aug 11, 2022 · 6 comments

Comments

@rudolphpienaar
Copy link
Member

No description provided.

@Quintinus98
Copy link
Contributor

@rudolphpienaar can I work on this issue?
Also can you provide more detail on this issue?

@jennydaman
Copy link
Collaborator

@Quintinus98 I don't think this issue is ready to be worked on yet.

Under some circumstances, (either a feed has been shared with you, or your username is "chris") the user is able to see files owned by a different user. Currently the ChRIS_ui "Library" is able to browse a user's own files but not the files of different users.

However, there is a current blocker due to a backend issue: I'm not sure whether it's possible for a user to discover the usernames of other users (under /api/v1/, it is possible to do from /chris-admin/). @jbernal0019 @rudolphpienaar any insights?

@Quintinus98
Copy link
Contributor

Okay I understand @jennydaman. I don't think a user should have the ability to see another user's feed and I also think it would not be a good idea.
Unless the other user lists out their feed for public use, it may be considered violation of user data.

There could be a feature allowing users to publicly list one or more of their feed and another to allow users access public feed. What do you think?

@jennydaman
Copy link
Collaborator

@Quintinus98 it's a good idea, and one that is implemented by https://terra.bio where there exists "public feeds" (workspaces in terra-speak) which everyone can view as read-only or clone to their own account. To support this in ChRIS we would need to first implement it as a backend feature.

Currently it works like this: are private to the user who created it, except for under the following conditions:

  • feed is shared with someone else
  • someone else's username is "chris" (the "chris" user is hard-coded as an edge case to be omniscient)

@Quintinus98
Copy link
Contributor

Okay that's great @jennydaman

I sent you a message on Matrix, please could you look at it and guide me on it. My Username is David Obodo

@jennydaman
Copy link
Collaborator

Continuing this discussion in FNNDSC/ChRIS_ultron_backEnd#453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants