Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espresso migration #46
Espresso migration #46
Changes from 12 commits
631874a
26ac754
73735d4
66f137b
2591c33
853a470
03cfd37
4d7f7d4
dc9f43b
1a12259
1d62c1f
8faf6d4
8d890c3
8fc2fb1
8572963
015cc1a
00490b2
5c576f6
804b034
7a1d231
f95942e
359b895
2fdf356
8e68bc8
f75e6bc
f7d2e02
ffd396e
d8322f3
90e12dd
4210058
64c026c
9d55ff3
78244ef
4037501
ee6519c
5813618
74222a3
c719f27
eec62f3
3721574
bbb8757
6b9cda3
775dbd3
60a1d61
1a43eaa
32c8a2f
aea5b46
b459a47
8b5d7f3
4d1068b
39e8496
71d78a1
c8fe3c5
46dbb2f
fd55f28
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between this and
nitro-node-dev-testnode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
ghcr.io/espressosystems/nitro-espresso-integration/nitro-node-dev:integration
eventually but it's currently necessary to use a local docker image for testing because we haven't merged @zacshowa's E2E changes in nitro and they will be needed for this upgrade test. So I guess it's a locally tagged image.