Update espresso-sequencer-go with new LC ABI #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the block height from the first snapshot after the height in the justification it uses the latest height in the LC contract. Currently not 100% convinced about correctness but also believe it should work because any newer tree still contains the header of interest.
Sneh1999
reviewed
Sep 16, 2024
arbnode/batch_poster.go
Outdated
| @@ -506,23 +506,28 @@ func (b *BatchPoster) addEspressoBlockMerkleProof( | |||
| return fmt.Errorf("this msg has not been included in hotshot") | |||
| } | |||
|
|
|||
| snapshot, err := b.lightClientReader.FetchMerkleRoot(jst.Header.Height, nil) | |||
| _, err = b.lightClientReader.FetchMerkleRoot(jst.Header.Height, nil) | |||
There was a problem hiding this comment.
Do we need to fetch the merkle root now?
There was a problem hiding this comment.
It seems that the only thing we needed from the snapshot was the hotshot height. I think were fine to remove this now.
There was a problem hiding this comment.
Why do we still need this call at all?
|
This seems correct because the validated height should be equivalent to the latest snapshot height |
We're not comfortable with the previous change because making a proof w.r.t to the newest finalized state may cause issues if the batch poster is lagging behind. This is currently not easy to test so we decided to revert back to the old flow.
sveitser
requested review from
ImJeremyHe,
alysiahuggins and
jbearer
as code owners
Sneh1999
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the block height from the first snapshot after the height in the justification it uses the latest height in the LC contract. Currently not 100% convinced about correctness but also believe it should work because any newer tree still contains the header of interest.
Closes #229