-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the global state for HotShot height #210
Conversation
969c55a
to
1eef4e6
Compare
384dd42
to
ded5276
Compare
ded5276
to
5581b71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ImJeremyHe I would suggest we merge my PR first. This would make the changes in this PR cleaner and the tests will also pass for this PR
cfb44c7
to
b790373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but one question. I'm also fine with not addressing this right now because we can't panic due to an error in the Message in the replay binary anyway so we will probably have to make significant changes in that region anyway.
Remove the extra global state that we added for the hotshot block height. We don't need this anymore for following reasons:
arbitrum-sdk
, without any change.This PR: