Add SwitchSequencer #110
Merged
Add SwitchSequencer #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
philippecamacho,
sveitser and
jbearer
as code owners
ImJeremyHe
force-pushed
the
jh/escape-hatch
branch
2 times, most recently
from
984dddd
to
f2d8252
Compare
jbearer
reviewed
Apr 2, 2024
sveitser
reviewed
Apr 9, 2024
ImJeremyHe
force-pushed
the
jh/escape-hatch
branch
from
3ed015e
to
0535a68
Compare
ImJeremyHe
force-pushed
the
jh/escape-hatch
branch
3 times, most recently
from
fb7d0bf
to
e2bc61e
Compare
ImJeremyHe
force-pushed
the
jh/escape-hatch
branch
from
e2bc61e
to
8ba1b3b
Compare
nomaxg
reviewed
Apr 11, 2024
| if s.IsRunningEspressoMode() { | ||
| return nil | ||
| } | ||
| log.Info("Switching to espresso sequencer") |
There was a problem hiding this comment.
Can we log the drift time and exactly how far we have drifted when we switch?
nomaxg
reviewed
Apr 11, 2024
| return nil | ||
| } | ||
| s.mode = SequencingMode_Centralized | ||
| log.Info("Switching to centrialized sequencer") |
There was a problem hiding this comment.
Same here, let's log precisely why we are switching
nomaxg
reviewed
Apr 11, 2024
| return err | ||
| } | ||
|
|
||
| if s.lightClient != nil { |
There was a problem hiding this comment.
Log a message like "light client not specified, we will only be sequencing mode"
nomaxg
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.