Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitro espresso upgrade follow up #228

Open
sveitser opened this issue Sep 16, 2024 · 0 comments
Open

Nitro espresso upgrade follow up #228

sveitser opened this issue Sep 16, 2024 · 0 comments

Comments

@sveitser
Copy link
Collaborator

sveitser commented Sep 16, 2024

Currently we enable the espresso integration via the chain config

case 35:
// Espresso marketplace compatible ArbOS version.
chainConfig.ArbitrumChainParams.EnableEspresso = true

If we imagine that our integration code at some point ends up in upstream nitro it should be possible to upgrade to an arbos version that supports the integration without actually using it. So I think it would be more appropriate to turn on the espresso integration via a call to the setChainConfig pre-compile instead of enabling it directly when performing the ArbOS upgrade (as we do now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant