Add Option values to Explorer histogram data #705
Merged
+8
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data in the Explorer histogram can occasionally have a missing component. There are times when we have written Block Header information without having written the Block Payload. Due to this, it allows for the possibility of being able to query data for a Block that has the Header, but no paylaod. This will ultimately result in an error as the size of the block in question can not be determined. This will currently result in an error. The change is to allow for nullable values for things like block size. It should not happen with block time, but since block time is also a Option result, it doesn't hurt to also allow for it's value to be an Option as well.
Ayiga
requested review from
nomaxg,
sveitser,
jbearer and
imabdulbasit
as code owners
alysiahuggins
approved these changes
Sep 26, 2024
imabdulbasit
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #703
This PR:
Updates the
ExplorerHistogramfields for bothtimeandsizeto haveOptionvalues, which can result in anullvalue coming down to the client.