Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I04: Argument naming conflict #2075

Open
alysiahuggins opened this issue Sep 26, 2024 · 0 comments
Open

I04: Argument naming conflict #2075

alysiahuggins opened this issue Sep 26, 2024 · 0 comments
Labels
audit contracts

Comments

@alysiahuggins
Copy link
Contributor

Affected Code: LightClient.sol (line 355)

Summary: The argument name threshold (the affected code) is the same
as the threshold (on line 93) field in the StakeTableState struct, which
could lead to confusion or unintended behavior.

Suggestion: The argument name threshold should be renamed to
blockThreshold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit contracts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alysiahuggins