Key Management and Config File for Validator Onboarding #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialization or test initialization
…eer_validators set other nodes' default pub key and stake value during initialization
…dator Config file for validator
Sishan/scripts gen keypair
…r_onboarding_after_pull
|
Sishan Long seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dailinsubjam
changed the title
dailinsubjam
requested review from
bfish713,
jbearer,
shenkeyao,
elliedavidson and
rob-maron
4 tasks
This reverts commit 0ca0a4f.
bfish713
approved these changes
Nov 9, 2023
rob-maron
approved these changes
Nov 9, 2023
| @@ -54,12 +54,9 @@ impl BLSPrivKey { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(clippy::incorrect_partial_ord_impl_on_ord_type)] | |||
There was a problem hiding this comment.
I'm good with this as long as it still works as intended ! I wonder why we implemented it this way to begin with
There was a problem hiding this comment.
I'm also wondering about that. In the beginning the implementation on this was very long ago, and later implementation just follow that. There are more discussions on whether we want to keep this on zullip.
| let config_file_as_string: String = fs::read_to_string(config_file.as_str()) | ||
| .unwrap_or_else(|_| panic!("Could not read config file located at {config_file}")); | ||
| let config_toml: NetworkConfigFile = | ||
| toml::from_str::<NetworkConfigFile>(&config_file_as_string) | ||
| let config_toml: NetworkConfigFile<TYPES::SignatureKey> = |
There was a problem hiding this comment.
This file is clean! Love it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Designs:
config/ValidatorConfigExamplefor reference), it would be better to generate it rather than read it from config file, and also ourHotshotConfigdoes contain the secret key originally for signning, so it's fine.gen_launcher::<TestTypes, MemoryImpl>(0)is to identifynode_idfor key pair (pk & sk) generation, sincebuild_system_handle()incrates/testing/src/task_helpers.rsneeds launcher with different node id.Main review parts:
orchestrator/src/config.rs,crates/types/src/lib.rs.