Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic metrics to support outside validators #1748

Closed
7 tasks done
dailinsubjam opened this issue Sep 14, 2023 · 2 comments · Fixed by #1852
Closed
7 tasks done

Basic metrics to support outside validators #1748

dailinsubjam opened this issue Sep 14, 2023 · 2 comments · Fixed by #1852
Assignees
Labels

Comments

@dailinsubjam
Copy link
Contributor

dailinsubjam commented Sep 14, 2023

We have metric code already, we can probably just launch with what we previously had and then get feedback on it during the testnet.

@dailinsubjam
Copy link
Contributor Author

Might be the same issue as #1564

@dailinsubjam
Copy link
Contributor Author

dailinsubjam commented Sep 20, 2023

For metrics, we do have ConsensusMetrics and NetworkingMetrics, but except for a few (incoming_message_count, outgoing_message_count, message_failed_to_send, outstanding_transactions, outstanding_transactions_memory_size), for all of others, we never really use them. I’m trying to enable the useful metrics in this task.

@dailinsubjam dailinsubjam linked a pull request Oct 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant