Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we not remove resolved_early from ResolveProposal event because multisig_voting don't have concept of early_resolution_vote_threshold? #70

Open
vpanchal-supra opened this issue Sep 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@vpanchal-supra
Copy link

As multisig_voting module does not have a concept of early_resolution_vote_threshold and it only considers min_vote_threshold so should we not remove resolved_early from ResolveProposal.

  • Right now every time ResolveProposal event is emitted with resolved_early=true because right now proposal with more than min_vote_threshold is considered as early proposal.
@vpanchal-supra vpanchal-supra added the enhancement New feature or request label Sep 17, 2024
@vpanchal-supra vpanchal-supra changed the title Should we not remove resolved_early from ResolveProposal event because multisig_voting don't have concept of early_resolution_vote_threshold Should we not remove resolved_early from ResolveProposal event because multisig_voting don't have concept of early_resolution_vote_threshold? Sep 17, 2024
@sjoshisupra
Copy link

@vpanchal-supra agreed. Assigning this to @nizam-supraoracles , however, whether this should be part of tge would have to be coordinated with @arundsupra depending upon code freeze date. As it is, this is merely a cleanup and not a critical bug.

@vpanchal-supra
Copy link
Author

Yes Dr. @sjoshisupra, This is just an optimization related issue.

@nizam-supraoracles
Copy link

As discussed with Dr. @sjoshisupra, this issue is still under debate due to the use of the can_be_resolved_early function. We're unsure if the resolved_early field will be required by the frontend or somewhere in governance dashboard. Therefore, we can leave this issue unresolved for now until we confirm whether this information is needed by the governance dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants