Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdct 3993 - add padding between text and edit button in entity row #764

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

britt-mo
Copy link
Contributor

@britt-mo britt-mo commented Sep 19, 2024

Description

There wasn't any padding between the text and edit button, which was visible when the title went long
Screenshot 2024-09-19 at 3 02 58 PM

change:
This change is viewable in all Entity Rows

Screenshot 2024-09-19 at 3 02 35 PM

Related ticket(s)

CMDCT-3993


How to test

Create a WP, see table in the WP has padding. Create SAR, see that initiatives table has correct padding.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

gmrabian
gmrabian previously approved these changes Sep 20, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ntsummers1 ntsummers1 self-requested a review September 20, 2024 14:31
Copy link
Contributor

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this adds the bump on mobile, might be slick to add a media query!
Screenshot 2024-09-20 at 10 31 33 AM

Copy link

codeclimate bot commented Sep 20, 2024

Code Climate has analyzed commit d6836db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.7% (0.0% change).

View more on Code Climate.

@britt-mo britt-mo merged commit fdeaa49 into main Sep 23, 2024
22 checks passed
@britt-mo britt-mo deleted the cmdct-3993 branch September 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants