Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace indentation issues #222

Open
ramonsmits opened this issue Sep 5, 2024 · 1 comment
Open

Whitespace indentation issues #222

ramonsmits opened this issue Sep 5, 2024 · 1 comment

Comments

@ramonsmits
Copy link
Contributor

ramonsmits commented Sep 5, 2024

@EliasOenal I'm considering some small refactorings to unify and cleanup the whitespace in the flex decoder. The file is a little messy. Would you accept a PR that fixes whitespace indentation and tries to keep the code pretty much identical as is?

Alternatively we could reformat the whole file with a specific code formatter. That would be great for future changes and auto formatting but it would make it harder to compare changes with prior versions.

@ramonsmits ramonsmits changed the title Whitespace Whitespace indentation issues Sep 5, 2024
@EliasOenal
Copy link
Owner

Yes, please make a separate commit for just the whitespace changes and as needed another one for non-whitespace refactoring. As of now the project overall does not have consistent formatting, but I'd be happy to discuss options for this. Ideally we'd use something that can be run from GitHub CI. Maybe we could add two targets to cmake to verify formatting (used for CI) and to apply formatting. I know clang-format is popular, do you have any recommendation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants