Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data format command broken for HadCRUT4: too many months? #3648

Open
alistairsellar opened this issue Jun 7, 2024 · 1 comment
Open

data format command broken for HadCRUT4: too many months? #3648

alistairsellar opened this issue Jun 7, 2024 · 1 comment

Comments

@alistairsellar
Copy link
Contributor

Describe the bug
The esmvaltool data format (or prepare) command fails for HadCRUT4:

$ esmvaltool data prepare HadCRUT4
<snip>
2024-06-07 12:43:03,660 UTC [23736] INFO    [NCL] (0)	INFO    fatal: in format_time (esmvaltool/cmorizers/data/formatters/utilities.ncl), incorrect number of timesteps in input data: 2028 expected, 2062 found
2024-06-07 12:43:03,660 UTC [23736] INFO    [NCL] 
2024-06-07 12:43:03,660 UTC [23736] INFO    Formatting successful for dataset HadCRUT4

(Note also the erroneous reporting of success.)

The error message suggests that the code is hard-wired for 169 years of monthly data, but that additional months have been added in an update to the source data.

Attachment: main_log_debug.txt
@valeriupredoi
Copy link
Contributor

well, the "success" comes from NCL returning code 0 which is, usually, actual huzzah 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alistairsellar @valeriupredoi