chore: refactor eox-map and convert code from ts to js
#1206
+4,362
−3,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…, layer, generate as js code
4 tasks
silvester-pari
approved these changes
Sep 26, 2024
RobertOrthofer
approved these changes
Sep 26, 2024
Comment on lines
+106
to
+115
| if (newControls) { | ||
| const keys = /** @type {ControlType[]} **/ Object.keys(controls); | ||
| for (let i = 0, ii = keys.length; i < ii; i++) { | ||
| const key = /** @type {ControlType} **/ keys[i]; | ||
|
|
||
| // Add or update the control using the helper function | ||
| // @ts-expect-error - Error throwing even type is declared. | ||
| addOrUpdateControl(EOxMap, oldControls, key, controls[key]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Unless I'm missing something, the only thing missing here are the round parenthesis ( ) around the variable to perform a proper type cast.
Suggested change
| if (newControls) { | |
| const keys = /** @type {ControlType[]} **/ Object.keys(controls); | |
| for (let i = 0, ii = keys.length; i < ii; i++) { | |
| const key = /** @type {ControlType} **/ keys[i]; | |
| // Add or update the control using the helper function | |
| // @ts-expect-error - Error throwing even type is declared. | |
| addOrUpdateControl(EOxMap, oldControls, key, controls[key]); | |
| } | |
| } | |
| if (newControls) { | |
| const keys = /** @type {ControlType[]} **/ (Object.keys(controls)); | |
| for (let i = 0, ii = keys.length; i < ii; i++) { | |
| const key = keys[i]; | |
| // Add or update the control using the helper function | |
| addOrUpdateControl(EOxMap, oldControls, key, controls[key]); | |
| } | |
| } |
| @@ -114,7 +141,7 @@ export class EOxMapCompare extends TemplateElement { | |||
| () => html` | |||
| <div class="eox-map-compare"> | |||
| <div class="eox-map-compare__first"> | |||
| <slot name="first"></slot> | |||
| <slot name="first">hujhjjh</slot> | |||
There was a problem hiding this comment.
minor typo, it's spelled Juhuuu! (Hooray!) in German ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
eox-maprefactored version is released.Screenshots/Videos
Checklist before requesting a review