Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCR-to-VELOC differences #4

Open
adammoody opened this issue Sep 10, 2018 · 3 comments
Open

SCR-to-VELOC differences #4

adammoody opened this issue Sep 10, 2018 · 3 comments

Comments

@adammoody
Copy link
Contributor

adammoody commented Sep 10, 2018

The VELOC API is missing some semantics needed for SCR. Most of these can be worked around, but I'll build a list to record where we stand:

  1. No support for non-checkpoint output sets, e.g., SCR_Start_output. VELOC assumes each output set is a checkpoint.
  2. No ability for app to ask when to checkpoint, i.e., SCR_Need_checkpoint
  3. No ability for app to ask whether it should exit, i.e., SCR_Should_exit
  4. Route_file also renames file whereas SCR keeps the same file name and only changes the path
  5. Because veloc does not return checkpoint name to application, app must track a name-to-id map in an external file, so this map may become out of sync with checkpoints that are actually available
@adammoody
Copy link
Contributor Author

Looks like we had and lost some of these functions in the change over to master:

#ifndef _VELOC_H

@bnicolae
Copy link
Contributor

I've added preliminary support for the SCR wrapper. Specifically, VELOC now flushes the original file names to stable storage (but still keeps its own names for local storage). Also, the restart works as long as the user specifies the original file name that goes with a specific checkpoint name and version. The user does not need to remember this, we could provide it automatically. However, the semantic of route_file on restart is not well defined for now (should the original file name be NULL on restart and get ignored?)

@bnicolae
Copy link
Contributor

This issue stayed inactive for a long time. However, it is still relevant and will be revisited eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants