Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to distinguish spack tests in validation_tests directory #47

Open
shahzebsiddiqui opened this issue Nov 22, 2022 · 0 comments
Open

Comments

@shahzebsiddiqui
Copy link
Contributor

@wspear

The validation_tests directory contains a lot of tests and it is not clear which ones invoke spack test and which one are not. It would be better to either remove all test that invoke spack test from this repo, if there is a need to keep them around i would suggest put them in a separate directory so its easier to keep track of them.

One option would be to have two top-level directories validation_tests and spack_tests. I suspect there will be translation as test migrates from validation_tests --> spack_tests when a package supports spack test. It is something to consider, i am trying to distinguish which tests should run from E4S Testsuite and which ones run from spack test and i dont want to write redundant tests from two different test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant