-
Notifications
You must be signed in to change notification settings - Fork 1
Questions #1
Comments
I will go and fix Nr. 1 right away in .4 |
Tested |
Good I'll drop you PR :) FYI:
can be easily refactored into My bad, it's an ES7 proposal you will need to run your code into babel before. What you can do is: var isScannable = (self.scanForExts.indexOf(ext) > -1) |
I see. Well, I didn't know of some of the niceties that JS had! But it'd be nice if you could PR that 3rd point. I just implemented 1 and 2. |
@IngwiePhoenix sure I'll take car of that ;) |
Allright. I'll be up for quite a while from hereon out, so i might catch it as you post it. :) |
Done, #2 is merged. :) |
#3 is merged. Oops, actually I should've thought about this beforehand; because if the user would also add JS into the list, it would be possibly duplicated. So, that made quite a lot of sense, it's why I merged it. |
Hey thank's again @IngwiePhoenix :)
I have a few questions:
paths
are given (https://github.com/DragonsInn/bird3-purifycss-webpack-plugin/blob/master/index.js#L16) ?merge
dependancy and useArray.concat
instead. Same here (https://github.com/DragonsInn/bird3-purifycss-webpack-plugin/blob/master/index.js#L22).I will be more than pleased to drop you PR, just need to check these things with you before 👍
The text was updated successfully, but these errors were encountered: