Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview deployment #379

Open
weyert opened this issue Aug 26, 2024 · 3 comments
Open

Preview deployment #379

weyert opened this issue Aug 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@weyert
Copy link

weyert commented Aug 26, 2024

What problem will this feature address?

I would be interested in having a feature that allow preview deployment based on pull requests

Describe the solution you'd like

When a pull request is raised it will start a deployment to a temporary domain, e.g. pr15-<app>.dokdeploy.com.
Potentially, consider allowing a different wildcard domain for the preview deployments, e.g. *.dokdeploy.app

The deployment will always have predefined set of dokdeploy environment variables defined, similar to how Vercel does it: https://vercel.com/docs/projects/environment-variables/system-environment-variables

Describe alternatives you've considered

Non yet

Additional context

In some projects you need to know the domain the project is hosted on at build-time and not only at runtime

@weyert weyert added the enhancement New feature or request label Aug 26, 2024
@weyert
Copy link
Author

weyert commented Aug 26, 2024

I am happy to try to implement this functionality, if anyone could point to the right places in the code, where I should I start

@Siumauricio
Copy link
Contributor

Hi @weyert , I like the idea we have the following:

We have 3 different ways to define a service

  1. Application ( Simple application )
  2. Databases
  3. Docker compose

According to github docs this is the implementation we should follow https://docs.github.com/en/rest/deployments/deployments?apiVersion=2022-11-28

I'm thinking if we should only provide preview deployments only for applications, since for databases and docker compose could be kinda different and more complicated to handle it

@sangdth
Copy link

sangdth commented Sep 4, 2024

I'm looking forward to this feature. If you don't mind please loop me in, I would like to give a hand as well as learn more about Dokploy development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@weyert @sangdth @Siumauricio and others