Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return from shaw_opening_angle_method is strange / optimization #48

Closed
amoodie opened this issue Mar 30, 2021 · 2 comments
Closed

Return from shaw_opening_angle_method is strange / optimization #48

amoodie opened this issue Mar 30, 2021 · 2 comments
Labels
enhancement New feature or request planform

Comments

@amoodie
Copy link
Member

amoodie commented Mar 30, 2021

The returned objects from the shaw_opening_angle_method is a flattened array. We know the array shape as an input though, so it probably makes more sense to return the reshaped arrays of sea_angles.

Additionally, there is another array shoreangles created, but I'm not clear on what this does.

There is probably quite a bit more optimization that can be done to this method/implementation though, so it would be a good target for a fun afternoon.

@amoodie amoodie added enhancement New feature or request planform labels Mar 30, 2021
@elbeejay
Copy link
Member

Can confirm some optimization is needed. Run into segmentation faults when trying to process larger arrays (e.g., those from remote sensing imagery - example below has shape (4398, 5882) which equates to 25869036 values).

Example using the fly_mask.npy array stored in zip file: fly_mask.zip

fly = np.load('fly_mask.npy')
OAP = dm.plan.OpeningAnglePlanform(fly)

@amoodie
Copy link
Member Author

amoodie commented Jul 17, 2024

I am closing this per #144, which greatly improved things. I can also confirm that the Fly River delta data can be processed and return a reasonable result.

image

@amoodie amoodie closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planform
Projects
None yet
Development

No branches or pull requests

2 participants