Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking to contour_threshold for creating various masks #105

Open
amoodie opened this issue Mar 9, 2022 · 0 comments
Open

Add checking to contour_threshold for creating various masks #105

amoodie opened this issue Mar 9, 2022 · 0 comments
Labels
enhancement New feature or request planform

Comments

@amoodie
Copy link
Member

amoodie commented Mar 9, 2022

A point that has tripped me up a few times now is that the value to contour_threshold needs to be adjusted when creating a mask via the MPM methods. I.e., the default value of 75 is outside the range of the values in the MPM mean_image, which is always in [0, 1].

Two ideas, both of which would be helpful, I think.

  1. Change the setup so that the default value when creating via MPM is 0.75 and when creating via OAP is 75. Add this to documentation and testing and it would be fine. Regardless of the default value, another value can always be supplied.
  2. When going to extract the contour in the mask creating bits here, add a check that one and only one contour has been found. If 0 or >1 are found, raise an error and stop. Possibly suggest increasing the max_disk value in the error?. Related: if 0 contours are found, return the range of the values in the error, which might be helpful.

issue created by discussion in #104

@amoodie amoodie added enhancement New feature or request planform labels Mar 9, 2022
@amoodie amoodie mentioned this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planform
Projects
None yet
Development

No branches or pull requests

1 participant