Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA Breach Notification for Disabled Severity Level #10662

Open
1 of 3 tasks
c3r63ru5 opened this issue Aug 1, 2024 · 0 comments
Open
1 of 3 tasks

SLA Breach Notification for Disabled Severity Level #10662

c3r63ru5 opened this issue Aug 1, 2024 · 0 comments
Labels

Comments

@c3r63ru5
Copy link

c3r63ru5 commented Aug 1, 2024

Bug description
I think I stumbled over a bug and found the fix for me, posted in Slack without response before I opened this. When you disable SLA for a severity level, all findings in this category get alerted as SLA breach. Looking at the database content, the sla_expiry_date is set to NULL (mysql). util.py will check the value of sla_age and if None (which is the case) set it to 0. Few lines later when age == 0, you alert an SLA breach. Continuing instead of setting the sla_age = 0 fixed the issue for me.

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to Configuration / SLA Configuration
  2. Disable "Enforce Low Finding SLA Days"
  3. Enable Notifications for SLA Breaches
  4. Run python manage.py sla_notifications

Expected behavior
No notifications for findings without an SLA (in this case low severity), instead all findings without SLA are marked as SLA breach.

Deployment method (select with an X)

  • Docker Compose (Migrated DB to MySQL 8)
  • Kubernetes
  • GoDojo

Environment information

  • DefectDojo version v. 2.36.5 ( release mode )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant