Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Profiler does not support macOS #3625

Open
nuxzero opened this issue May 3, 2024 · 4 comments
Open

Continuous Profiler does not support macOS #3625

nuxzero opened this issue May 3, 2024 · 4 comments
Assignees
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one profiling Involves Datadog profiling

Comments

@nuxzero
Copy link

nuxzero commented May 3, 2024

Current behaviour

I'm upgrading ddtrace from version 0.45 to 1.22.0 and testing with macOS agent on my local, but profiling data not showing and get the below warning that it's not supported macOS. However, it used to work with version 0.45.

W, [2024-05-02T13:30:42.093230 #7931] WARN -- ddtrace: [ddtrace] Profiling was requested but is not supported, profiling disabled: Your ddtrace installation is missing support for the Continuous Profiler because macOS is currently not supported by the Datadog Continuous Profiler. Get in touch with us if you're interested in profiling your app!

Screenshot 2567-05-03 at 07 27 59

Expected behaviour

It should show profiling data from the trace.

Steps to reproduce

  1. Go to APM Traces
  2. Click a trace
  3. Click Code Hotspots
  4. Click Breakdown tab

How does datadog help you?

Environment

  • datadog version: Datadog Agent 7.52.1
  • Configuration block (Datadog.configure ...):
    initializers/datadog.rb file
    c.service = service_name
    c.version = service_version
    c.env = service_env
    c.profiling.enabled = profiling_enabled
    config.ru file
    require "datadog/profiling/preload"
    ...
  • Ruby version: 2.7.4
  • Operating system: macOS 14.4.1
  • Relevant library versions: ddtrace 1.22.0
@nuxzero nuxzero added bug Involves a bug community Was opened by a community member labels May 3, 2024
@ivoanjo ivoanjo self-assigned this May 7, 2024
@ivoanjo ivoanjo added the profiling Involves Datadog profiling label May 7, 2024
@ivoanjo
Copy link
Member

ivoanjo commented May 7, 2024

Hey @nuxzero, thanks for getting in touch!

Indeed back in the 0.x series the profiler was able to work on macOS (with some limitations -- such as not supporting cpu-time).

What happened was during the 1.x series we rewrote most of the profiler, and the rewritten profiler does
not currently* work on macOS, other than inside docker. (*There's some support for development, but it needs a few
manual steps)

We don't often have requests for macOS support -- can you tell us more about your use-case?

@nuxzero
Copy link
Author

nuxzero commented May 8, 2024

Thank you for replying @ivoanjo . Right now I’m enabling profiler in my service and I would like to test it on my local environment before deploying it. However, I will try with Docker agent instead.

@ivoanjo
Copy link
Member

ivoanjo commented May 8, 2024

Got it! It should work seamlessly within docker, do let us know if you run into any issues.

Testing the profiler locally is something we ourselves make use of -- hence my mention of there being some support we use for development. Unfortunately, there's a few roadblocks to be solved (mostly around distribution) before we can support it officially again.

@ivoanjo ivoanjo added feature Involves a product feature feature-request A request for a new feature or change to an existing one and removed bug Involves a bug feature Involves a product feature labels May 14, 2024
@ivoanjo ivoanjo changed the title Continuous Profiler not working after upgrading to version 1.22.0 Continuous Profiler does not support macOS May 14, 2024
@ivoanjo
Copy link
Member

ivoanjo commented May 14, 2024

I've updated the ticket title and marked it as a feature request, since we explicitly are not supporting macOS in the profiler for now, BUT we're definitely wanting to know about folks that miss this + what's your use case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one profiling Involves Datadog profiling
Projects
None yet
Development

No branches or pull requests

2 participants