Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redis] Redisson instrumentation only covers synchronous part of async RedisConnection.send. #7510

Open
mstyura opened this issue Aug 26, 2024 · 1 comment
Open

[redis] Redisson instrumentation only covers synchronous part of async RedisConnection.send. #7510

mstyura opened this issue Aug 26, 2024 · 1 comment
Assignees
@amarziali
Labels
inst: redis Redis instrumentation type: feature request
Milestone
1.40.0

Comments

@mstyura
Copy link

mstyura commented Aug 26, 2024

Currently instrumentation of Redisson's RedisConnection only tracks the synchronous part of send which leads to wrong command execution time reported (it also seems to miss any error which might be returned by response from Redis). Possibly the proper instrumentation must instrument return value of RedissonInstrumentation.send which is netty's ChannelFuture. Such approach is implemented by open telemetry instrumentation for Redisson.
@mstyura mstyura changed the title [redis] Redisson instrumentation only count synchronous part of async RedisConnection.send. [redis] Redisson instrumentation only covers synchronous part of async RedisConnection.send. Aug 26, 2024
@PerfectSlayer PerfectSlayer added the inst: redis Redis instrumentation label Aug 27, 2024
@amarziali amarziali mentioned this issue Sep 5, 2024
Merged
5 tasks
@amarziali amarziali self-assigned this Sep 6, 2024
@amarziali amarziali added this to the 1.40.0 milestone Sep 6, 2024
@amarziali
Copy link
Collaborator

Will be fixed in 1.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amarziali amarziali

Labels
inst: redis Redis instrumentation type: feature request
Projects
None yet
Milestone
1.40.0
Development

No branches or pull requests
3 participants
@mstyura @PerfectSlayer @amarziali