Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Error Exceptions thrown in spring controllers cause the span error flag to be set. #7141

Open
Xyaren opened this issue Jun 7, 2024 · 1 comment

Comments

@Xyaren
Copy link
Contributor

Xyaren commented Jun 7, 2024

For example if spring throws a NoResourceFoundException this would result in a 404 response, which is totally expected behaviour.
Unfortunately the span is still flaged as an error.

This causes a spam of error-flagged traces even for harmless stituations.
The same applies to custom created Exceptions that are annotated with @ResponseStatus or any spring controller advices that transalte i.e. a EntityNotFoundException into a 204 response.

Example of a 404 causing the span to be tagged as error.
image

@Xyaren Xyaren changed the title Non-Error Exceptions thrown in spring controllers cause the errro flag to be set. Non-Error Exceptions thrown in spring controllers cause the span error flag to be set. Jun 7, 2024
@dgswan
Copy link

dgswan commented Jul 10, 2024

@Xyaren
We have the same thing in our project. It looks similar to #7288. Please see the answer #7288 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants