Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of alumni cutoff by footer bar! #7

Open
rhiju opened this issue Mar 2, 2023 · 1 comment · May be fixed by #11
Open

List of alumni cutoff by footer bar! #7

rhiju opened this issue Mar 2, 2023 · 1 comment · May be fixed by #11

Comments

@rhiju
Copy link
Member

rhiju commented Mar 2, 2023

Here's scheenshot -- can't see bottom few names:
https://daslab.stanford.edu/people/
Screen Shot 2023-03-02 at 10 17 08 AM

@tkaragianes
Copy link

This is happening because everything on the site is absolutely positioned and removed from the browser's normal layout engines. There is a script somewhere that is adding a height to the body and it appears to be calculating that incorrectly. The proper fix is to correct the outdated layout techniques, but that will require porting most of the pages to a more modern approach (which is simple enough and likely should happen anyway). However, as an immediate workaround, I can min-height the body on this page. We will have to update that every time we add new members or make changes to this page, so not a long-term solution.

@tkaragianes tkaragianes linked a pull request Mar 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants