Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image scraper ignores preferred language and uses all #225

Open
phtnk opened this issue Feb 25, 2022 · 4 comments
Open

Image scraper ignores preferred language and uses all #225

phtnk opened this issue Feb 25, 2022 · 4 comments

Comments

@phtnk
Copy link

phtnk commented Feb 25, 2022

The setting Movies > 'Scrapers - Images' > 'Preferred Language' is not applied with either automatic scraping or manual selection.
Forced language can be set to english and still images tagged in different languages appear. 'Only get images for...' below has no effect either.
Example:
Tried on Star Wars: Ep2, for Fanart with 'Any' preferred size which returns a 2160p image with spanish tag as first result and therefore chooses this via auto scrape. The same image is shown in several other languages - only 'forced language: english' is selected, though.
The media itself contains only english and german streams.

@DanCooper
Copy link
Owner

DanCooper commented Feb 25, 2022

"Media language" is not controlled by stream languages, it's set by the default language of the source and can be manually changed for any video via context menu. The language value will also be written to the NFO. That results in the following order how a video get his "media language":

  1. from NFO if NFO is existing and contains the node "language"
  2. from the default language that has been assigned to the source settings

I'm pretty shure the "Preffered Language only" function works if a video has a valid language assigned.

@phtnk
Copy link
Author

phtnk commented Feb 25, 2022

I checked what you suggested. The default language for new sources is set to en-US, which is also what this file is tagged as in the nfo.
I tried with 'force language' set to english, as well as 'only get images for the media language', both individually and combined.

In every case, when I delete the fanart for the entry and select via context menu '(Re)Scrape Selected Movies' > 'Automatic' > 'Fanart Only' it still selects the first listed entry, which is the mentioned image flagged TMDB and spanish. Same, when I double rightclick on the fanart.
emberImSelect

@DanCooper
Copy link
Owner

Fanart is the only image type that ignores language settings because most providers haven't provided language information for fanarts or tagged fanarts with languages even if they don't had any text in the image. Looks like that has been changed, so I've to check if ignoring the language for fanarts is still usefull.

@phtnk
Copy link
Author

phtnk commented Feb 26, 2022

Ah, got it. To be fair, I've been using EMM for eight years or so and this is the first time this happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants