Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide std::vector interfaces for our user data functions #898

Open
holke opened this issue Jan 19, 2024 · 0 comments · May be fixed by #1059
Open

Provide std::vector interfaces for our user data functions #898

holke opened this issue Jan 19, 2024 · 0 comments · May be fixed by #1059
Assignees
@Prasanna-Ponnusamy
Labels
enhancement Enhances already existing code good first issue Can be handled if you are new to t8code shouldn't take long Can be resolved in under 30 mins

Comments

@holke
Copy link
Collaborator

holke commented Jan 19, 2024

Many of our users have their data in std::vector.
To easen usage of t8code's user data handling functions, we should provide versions of them that accept std::vector instead of sc_array.
In particular

t8_forest_iterate_replace
t8_forest_partition_data
t8_forest_ghost_exchange_data
t8_forest_search

The implementation is quick: Create an sc_array view of the vector and call the sc_array variant of the function.
@holke holke added enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins good first issue Can be handled if you are new to t8code labels Jan 19, 2024
@Prasanna-Ponnusamy Prasanna-Ponnusamy linked a pull request Apr 10, 2024 that will close this issue
Create a view for std_vector input #1022
Closed
14 tasks
@Prasanna-Ponnusamy Prasanna-Ponnusamy linked a pull request Jul 19, 2024 that will close this issue
Test with vector as input #1059
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Prasanna-Ponnusamy Prasanna-Ponnusamy

Labels
enhancement Enhances already existing code good first issue Can be handled if you are new to t8code shouldn't take long Can be resolved in under 30 mins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test with vector as input DLR-AMR/t8code
Create a view for std_vector input DLR-AMR/t8code
2 participants
@holke @Prasanna-Ponnusamy