Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods do not seem to return models #163

Open
4 tasks done
jmsmkn opened this issue Aug 7, 2024 · 7 comments · May be fixed by #167
Open
4 tasks done

Some methods do not seem to return models #163

jmsmkn opened this issue Aug 7, 2024 · 7 comments · May be fixed by #167
Assignees

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Aug 7, 2024

Still returning dictionaries of objects:

  • c.images.iterate_all(...) -> nested image["files"][0]["file"] (Via .page(), works.)
  • c.upload_cases(...)
  • run_external_job
  • get_file
  • Fix # type: ignore
@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 7, 2024

Actually iterate_all might be okay?

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 7, 2024

get_file in tests? Looks like this is a direct call to the client. We should infer what endpoint is being called.

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 7, 2024

run_external_job ignores a bunch of type checks, too difficult with this messy sync/async setup.

@jmsmkn jmsmkn self-assigned this Aug 7, 2024
@chrisvanrun
Copy link
Contributor

chrisvanrun commented Aug 22, 2024

I assume the ModifiableMixin.create and siblings are also supposed to return a model?

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 23, 2024

If anything is returning a raw API response directly from the API it should be returning a model instead, add it to the list.

Do you think you can fix these?

@chrisvanrun
Copy link
Contributor

Yes, fixing them as I go while testing my change set.

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 23, 2024

Thanks

@chrisvanrun chrisvanrun linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants