Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads to archive items fail when CIV is file type and JSON sent #153

Open
jmsmkn opened this issue Nov 28, 2023 · 0 comments · May be fixed by #167
Open

Uploads to archive items fail when CIV is file type and JSON sent #153

jmsmkn opened this issue Nov 28, 2023 · 0 comments · May be fixed by #167
Assignees

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Nov 28, 2023

If you have a file type CIV (e.g. clinical-information-lung-ct) and try to upload a JSON object directly to that (e.g. {'age': 60, 'gender': 'FEMALE', 'smoking_status': 'Ex-smoker', 'clinical_category': None, 'regional_nodes_category': None, 'metastasis_category': None}) it will fail with ValueError: You can only upload one single file to a clinical-information-lung-ct interface..

This is kindof cryptic, as the solution is for the user to write the file to disk first, then send the name or Path object along.

We should detect this and handle it ourselves as the user should need to know about the details of how the CIV is stored within GC in order to upload it. However, we need to be careful as string values could just point to files.

@chrisvanrun chrisvanrun self-assigned this Aug 27, 2024
@chrisvanrun chrisvanrun linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants