Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelData Language was present in the proto, but was not accessible in the channel.go. Also missing ProtocolID #151

Open
daninmadison opened this issue Mar 1, 2023 · 0 comments
Open

ChannelData Language was present in the proto, but was not accessible in the channel.go. Also missing ProtocolID #151

daninmadison opened this issue Mar 1, 2023 · 0 comments

Comments

@daninmadison
Copy link
Contributor

I discovered this was missing and just submitted a Pull Request that contains code fixing this issue.

While fixing this, I also added support for the ProtocolID (protocol_id proto from Asterisk). Asterisk passes the protocol_id with the Channel. This is based on the underlying protocol. For chan_sip and PJSIP, this is the value of the SIP packet's Call-ID header.

Just submitted a Pull Request for both of these.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daninmadison