Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Server name missing in notifications #833

Open
GeckoBoy84 opened this issue May 12, 2023 · 6 comments · May be fixed by #985
Open

[Bug]: Server name missing in notifications #833

GeckoBoy84 opened this issue May 12, 2023 · 6 comments · May be fixed by #985
Assignees
Labels
Bug / Fix Something isn't working and may need a fix Medium Priority Needs attention, not urgent

Comments

@GeckoBoy84
Copy link
Collaborator

What is your request about?

Server name is not included in suspend notifications

Branch

main

Solution idea

Add the server name to suspend notifications

Controlpanel Logs

No response

Additional Info

No response

@GeckoBoy84 GeckoBoy84 added the Bug / Fix Something isn't working and may need a fix label May 12, 2023
@GeckoBoy84 GeckoBoy84 changed the title [Bug]: [Bug]: Server name missing in notifications May 12, 2023
@1day2die
Copy link
Collaborator

this is the case because once a user runs out of credits ALL servers get suspended obviously.

We have to keep this in mind thought and have to re-check the suspension logic because of the new billing cycles @IceToast

@GeckoBoy84
Copy link
Collaborator Author

Not necessarily, all servers get suspended that cannot be paid for, but if they are cheaper you might last another few billing periods. Additionally you currently #246 get an email for each service so there is no way to differentiate between them

@IceToast
Copy link
Collaborator

With the new billing cycle each server must get suspended individually and thus sending a individual mail and/or notification

@S0ly
Copy link
Member

S0ly commented May 15, 2024

and so have this been fixed in the dev branch ?

@S0ly S0ly added the Medium Priority Needs attention, not urgent label May 15, 2024
@S0ly
Copy link
Member

S0ly commented Jun 24, 2024

@IceToast please

@Ctrlpanel-gg Ctrlpanel-gg deleted a comment from S0ly Jun 24, 2024
@IceToast
Copy link
Collaborator

IceToast commented Jun 24, 2024

Nope it hasnt been fixed yet. The app/Notifications/ServersSuspendedNotification.php handles the notification with a generic "All servers" since back then all servers have been suspended without the period system.

This could be done easily tho. Adding a prop to the notification and hand over the server name/id to the notification handler:
app\Console\Commands\ChargeServers.php:131

@AGuyNamedJens AGuyNamedJens self-assigned this Jul 27, 2024
@AGuyNamedJens AGuyNamedJens linked a pull request Jul 27, 2024 that will close this issue
17 tasks
@AGuyNamedJens AGuyNamedJens linked a pull request Jul 27, 2024 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix Something isn't working and may need a fix Medium Priority Needs attention, not urgent
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

5 participants