From 4b768c6e2c13d2c39d41e477e4d3e11cfc3043c3 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Thu, 24 Aug 2023 02:27:06 -0400 Subject: [PATCH 1/2] Allow floaty bit to hide appropriately --- ember-velcro/src/modifiers/velcro.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ember-velcro/src/modifiers/velcro.ts b/ember-velcro/src/modifiers/velcro.ts index 80fac98..f8c35ab 100644 --- a/ember-velcro/src/modifiers/velcro.ts +++ b/ember-velcro/src/modifiers/velcro.ts @@ -88,11 +88,15 @@ export default class VelcroModifier extends Modifier { strategy, }); + const { referenceHidden } = middlewareData.hide; + Object.assign(floatingElement.style, { top: `${y}px`, left: `${x}px`, margin: 0, + visibility: referenceHidden ? 'hidden' : 'visible', }); + setVelcroData?.(middlewareData.metadata); }; From 21c18b4eddf386caed54379fe75f8354ef2a777e Mon Sep 17 00:00:00 2001 From: Tony Ward <8069555+ynotdraw@users.noreply.github.com> Date: Thu, 24 Aug 2023 07:55:14 -0400 Subject: [PATCH 2/2] Create fair-taxis-lay.md --- .changeset/fair-taxis-lay.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fair-taxis-lay.md diff --git a/.changeset/fair-taxis-lay.md b/.changeset/fair-taxis-lay.md new file mode 100644 index 0000000..2410740 --- /dev/null +++ b/.changeset/fair-taxis-lay.md @@ -0,0 +1,5 @@ +--- +"ember-velcro": patch +--- + +Fixes an issue with visibility