-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schematicannon can "print" any item(s) for free in certain containers. #6961
Comments
Can't reproduce this with FD baskets (I can't attach display items; it opens an inventory. Also the block isn't tagged create:safe_nbt so shouldn't be getting contents printed). Might be some third mod. Amendments does indeed add nbt data to hanging signs: https://github.com/MehVahdJukaar/amendments/blob/da6b5acc3d9fb03f2acba9179a4e32068de44138/common/src/main/java/net/mehvahdjukaar/amendments/common/tile/HangingSignTileExtension.java#L84-L89 |
This might be an issue in my mod pattern schematics, since it changes base function of the schematicannon, although ill have to look into why this would be happening regardless |
The Amendments part with the hanging signs I've actually reproduced with just Create, that's why I specifically mention not being able to reproduce the FD basket part (I don't see how to get single display items in those and they're not tagged to retain nbt) |
Some additional info and a work-around we devised for now: As far as I can tell, the main issue is that Amendments tacks on additional NBT, which Create blindly copies over (probably with the goal of bringing over sign text). Specifically, this is controlled by Our work-around for now has been to pull signs off that tag, so now they print blank, which is not ideal, but at least they don't print free stuff anymore. Once learning of this, we tested everything else on this tag and were able to reproduce the whole item-spawning-in thing with Create: Deco's colored Placards. As for the baskets, we stopped being able to reproduce it after taking signs off the tag list, so I blame a mod compatibility issue there. However, base Create's Placards are on that list, too, and don't magically manifest items. Do they have special handling that could be somehow expanded upon? |
They have special handling, deco needs to extend that handling to their own pacards. As for the signs, amendments shouldn't be adding nbt onto existing blocks but there isn't really a better option, so special casing will need to be done for that so it isn't copied over |
Gotcha. Is this something that'd be up to the Deco and Amendments authors, or is this within Create? To me, spawning in items is a big enough problem to at least consider the two as "soft" incompatibilities (or however Create reports work-around-able mod conflicts, if at all), at it only affects multiplayer and probably only public multiplayer at that. |
For Deco they'd have to fix that, for amendments we'll handle it |
Description
Little afraid to post this issue public but I was asked to post it on behalf of our server's team.
Certain blocks which contain single-slot "display" inventories (we were able to confirm this with the likes of Minecraft's Hanging Signs with Amendments installed and the Farmer's Delight Hanging Canvas Signs and Baskets) will "print" their display items when placed by a Schematicannon. This item can then be removed from the container by the offending player for a free item.
On our server, we have already observed players successfully spawning in:
The only effective mitigation, as far as I can tell, is to disable uploading schematics altogether.
I can provide an offending schematic if need be (GitHub won't let me attach
.nbt
files to issues), but the ones we took from players contain a single Hanging Sign (i.e.minecraft:oak_hanging_sign
) with the offending item slotted in, and one block for the sign to hang from.I suspect this has some pertinence to #6754?
Game Log
https://mclo.gs/Wsnp2vO
Debug Information
Client Info
Server Info
The text was updated successfully, but these errors were encountered: