Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network constants diversity #354

Open
OlivierBBB opened this issue Sep 16, 2024 · 0 comments
Open

Network constants diversity #354

OlivierBBB opened this issue Sep 16, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@OlivierBBB
Copy link
Collaborator

We need a solution to handle network constants for various networks, e.g.

  • CHAINID
  • BASEFEE
  • BLOCK_GAS_LIMIT
  • (before decentralization) COINBASE address

as well as for contexts where some of these hard-coded constants make no sense (Ethereum test suite.)

Several solutions are conceivable:

  • have several <network-name>-config.lisp files e.g. mainnet-config.lisp, sepolia-config.lisp, reference-tests-config.lisp and maybe adding build commands à la make mainnet-zkevm.bin
  • using a single ZKEVM_MODULES list and adding an option to the make zkevm.bin command to include the correct config constants file and producing the associated <network-name>-zkevm.bin file
  • not having such files in the project but generating them on the fly (there are only a few such files and they are short) when compiling the zkevm.bin
@OlivierBBB OlivierBBB added the help wanted Extra attention is needed label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants