Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange :guard in loginfo/constraints.lisp #232

Closed
DavePearce opened this issue Jun 5, 2024 · 1 comment · Fixed by #233
Closed

Strange :guard in loginfo/constraints.lisp #232

DavePearce opened this issue Jun 5, 2024 · 1 comment · Fixed by #233
Assignees
@letypequividelespoubelles

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented Jun 5, 2024 •
edited
Loading

This seems odd to me:

(defconstraint verticalization-row-6 (:guard (reduce + (for k [4 : 4] [IS_LOG_X k])))

It is one of the reasons causing a crash in #231. I will fix the crash, but the :guard looks odd.

@letypequividelespoubelles Thoughts?
@letypequividelespoubelles
Copy link
Contributor

Indeed. It's not wrong, but I'll rewrite it to make it more logical (and add force-bool btw).

@letypequividelespoubelles letypequividelespoubelles linked a pull request Jun 5, 2024 that will close this issue
style(loginfo): rewrite verticalisation constraint guard #233
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(loginfo): rewrite verticalisation constraint guard Consensys/linea-constraints
2 participants
@DavePearce @letypequividelespoubelles