Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICMI moving window is missing runtime test #4995

Open
BrianMarre opened this issue Jul 17, 2024 · 0 comments
Open

PICMI moving window is missing runtime test #4995

BrianMarre opened this issue Jul 17, 2024 · 0 comments
Assignees
@BrianMarre
Labels
component: tests unit tests good first issue signal new contributors where they can start PICMI pypicongpu and picmi related

Comments

@BrianMarre
Copy link
Member

The moving window configuration via PICMI introduced in #4987 is missing a runtime test.

A runtime test is necessary since moving window is a runtime only option and therefore this should be tested in the CI.
Unfortunately this is not currently possible since the PyPIConGPU runner lacks the ability to subdivide the device and running a PIConGPU simulation with moving window requires device splitting in the CI environment.

This runtime tested was therefore postponed and should be added after the runner has been refactored.
@BrianMarre BrianMarre mentioned this issue Jul 17, 2024
Merged
@steindev steindev added good first issue signal new contributors where they can start PICMI pypicongpu and picmi related component: tests unit tests labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianMarre BrianMarre

Labels
component: tests unit tests good first issue signal new contributors where they can start PICMI pypicongpu and picmi related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steindev @BrianMarre